feat(base-ops): grouped secret facts and resolver#22
Merged
Conversation
Support defining multiple secret values under a single group name via
secretGroup(). Add resolveSecret/requireSecret helpers that transparently
resolve a camelCase name (e.g. "netbirdApiKey") by trying exact match
first, then splitting into group + property ("netbird" + "apiKey").
Update vault-fact-store to read/write grouped secret specs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ecrets Vault may store numeric values (e.g. ports) that should be treated as strings in the secret spec. Convert numbers to strings during read so they pass validation and are usable as secret properties. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move secret resolution logic into InfrastructureFactsPool so modules can
call pool.requireSecret('netbirdApiKey') directly. The standalone
resolveSecret/requireSecret functions are kept as deprecated delegates.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretGroup()factory for defining multiple named secret values under a single group nameresolveSecret()/requireSecret()that transparently resolve camelCase names (e.g.netbirdApiKey) by exact match or group+property split (netbird+apiKey)Test plan
camelCaseSplitsedge cases (acronyms, single word, multi-word)secretGroup()factory and pool coexistence with simple secrets🤖 Generated with Claude Code